Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1196#discussion_r101908082
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1520,13 +1524,9 @@ void TNonblockingIOThread::breakLoop(bool error) {
::abort();
}
- // sets a flag so that the loop exits on the next event
- event_base_loopbreak(eventBase_);
+ // cause the loop to stop ASAP - even if it has things to do in it
+ event_base_loopexit(eventBase_, 0);
--- End diff --
+1
According to another look at the header doc, loopbreak is typically to be
called from inside the loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
