[
https://issues.apache.org/jira/browse/THRIFT-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873982#comment-15873982
]
ASF GitHub Bot commented on THRIFT-4077:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1198
THRIFT-4077: fix Appveyor warnings (VS2015) in PlatformSocket.h
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4077
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1198
----
commit 10673cc6e63a5e35446f4dbdcaa25361fd2ea6d6
Author: James E. King, III <[email protected]>
Date: 2017-02-20T03:12:04Z
THRIFT-4077: fix Appveyor warnings (VS2015) in PlatformSocket.h
----
> AI_ADDRCONFIG redefined after recent change to PlatformSocket header
> --------------------------------------------------------------------
>
> Key: THRIFT-4077
> URL: https://issues.apache.org/jira/browse/THRIFT-4077
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.11.0
> Environment: Appveyor CI
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> {noformat}
> C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning
> C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file
> C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp)
> [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
> C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note:
> see previous definition of 'AI_ADDRCONFIG' (compiling source file
> C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp)
> TPipe.cpp
> C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning
> C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file
> C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp)
> [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
> C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note:
> see previous definition of 'AI_ADDRCONFIG' (compiling source file
> C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp)
> C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning
> C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file
> C:\projects\thrift\lib\cpp\src\thrift\transport\TPipe.cpp)
> [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
> {noformat}
> from Appveyor CI build:
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/951
> It looks like we need to include the correct winsock header before we
> determine if AI_ADDRCONFIG needs to be defined.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
