[
https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956959#comment-15956959
]
ASF GitHub Bot commented on THRIFT-4071:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1238
THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI
Removed build jobs 2 and 4 as they were duplicates of 1 and 3 but on debian
instead of ubuntu, this adds too little value to justify the expense of two 40
minute builds.
Added compiler plug-in option to job 6 to make sure it is tested in CI.
Combined jobs 7 and 8 because there is enough time in the build to support
it.
Removed build job 9 but kept 10 because it uses debian in light of removing
2 and 4.
Removed build job 12 and 15 as they are redundant to 13 and 14 and add too
little value to justify the expense.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1238
----
commit 208edb0583cf4daa673f2553317448d2f3823db3
Author: James E. King, III <[email protected]>
Date: 2017-04-05T14:36:07Z
THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI;
ensure WITH_PLUGIN is tested somewhere
----
> Consolidate the Travis CI jobs where possible to put less stress on the
> Apache Foundation's allocation of CI build slaves
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-4071
> URL: https://issues.apache.org/jira/browse/THRIFT-4071
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Affects Versions: 0.10.0
> Environment: Travis CI
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> Based on INFRA-13477 it sounds like we need to start working on eliminating
> unnecessary build jobs of combining some of them. I emailed the dev mailing
> list but didn't hear back after 5 days, so I am proceeding with these changes:
> # We don't need to run cross tests on both debian andon ubuntu, especially
> since we're using a dockerfile that's practically identical between the two;
> one derives from the other. I'd like to recommend removing build jobs #2 and
> #4 (debian) and keeping the ubuntu ones.
> # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is
> a Debian build job with cmake, and eliminate #9 which is the same as #10 but
> on Ubuntu. I think it is adqeuately covered in other jobs.
> # We don't need to build the matrix of (boost threads, std
> threads)x(gcc,clang). Let's get rid of #12 which is boost threads with
> clang, and let's get rid of #15 which is std threads with gcc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
