[
https://issues.apache.org/jira/browse/THRIFT-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959624#comment-15959624
]
ASF GitHub Bot commented on THRIFT-3904:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/794
@jfarrell THRIFT-3904 and other, earlier commits already did the same
thing, so this PR can be closed.
> Typo in node tutorial leads to wrong transport being used
> ---------------------------------------------------------
>
> Key: THRIFT-3904
> URL: https://issues.apache.org/jira/browse/THRIFT-3904
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library, Tutorial
> Reporter: Mark Sonnabaum
> Assignee: Marek Kedzierski
> Fix For: 0.10.0
>
>
> In the node tutorial (tutorial/nodejs/NodeClient.js), lines like `transport =
> thrift.TBufferedTransport()` cause transport to be undefined, which later get
> replaced with the default, so this example does work.
> I found the issue when using `thrift.TFramedTransport()`, which was erroring
> on the server side. It took me a while to figure out that the transport was
> falling back to buffered, because I was actually assigning the transport to
> undefined.
> Changing the lines to assign thrift.TFramedTransport instead of
> thrift.TFramedTransport() fixed it for me.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
