Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1309#discussion_r128156875
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go",
" read_write_private\n"
" Make read/write methods
private, default is public Read/Write\n" \
" use_context\n"
- " Make service method
receive a context as first argument.\n")
+ " Make service method
receive a context as first argument, only go1.7+ is supported.\n")
--- End diff --
Breaking BC can be ok (happened before, see my commits) but if we remove
`use_context` we can make sure all RPCs will have the same signature starting
with `(ctx *Context, ...`.
To be more clear: I think adding context support is *very* worthwhile and
it's worth breaking BC for it (especially for a new release), but it would be
better to support `context` for all Go versions, not just Go>1.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
