[
https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309338#comment-16309338
]
ASF GitHub Bot commented on THRIFT-3983:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1456
THRIFT-3983: Fix generated maven packaging
ref <https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-3983>
---
* The origin PR is <https://github.com/apache/thrift/pull/1430>, so this
close #1430
* This PR depends on
[THRIFT-4439](https://issues.apache.org/jira/browse/THRIFT-4439), to pass CI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1456
----
commit 04a82de2e328d026563fa725fa1ffb3a850cf91f
Author: Robert Lu <robberphex@...>
Date: 2017-12-28T20:14:38Z
use dartlang repo
commit e40c23539543ba353bc0368e7b3c5c25b1bf9846
Author: Stephane Landelle <slandelle@...>
Date: 2017-11-30T23:08:56Z
Fix generated maven packaging
pom packaging is for empty modules. What you're deploying on maven central
is a jar artifact. Your current invalid pom.xml causes build tools such as sbt
to not be able to download your library!
----
> libthrift is deployed on central with pom packaging instead of jar
> ------------------------------------------------------------------
>
> Key: THRIFT-3983
> URL: https://issues.apache.org/jira/browse/THRIFT-3983
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9.3
> Reporter: Stéphane Landelle
> Priority: Blocker
>
> Hi,
> libthrift is deployed with a "pom" packaging on maven central, see
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/0.9.3/libthrift-0.9.3.pom
> <groupId>org.apache.thrift</groupId>
> <artifactId>libthrift</artifactId>
> <version>0.9.3</version>
> <packaging>pom</packaging>
> <name>Apache Thrift</name>
> This is very wrong. "pom" means "no jar, just a list of dependencies to be
> pulled transitively".
> As a consequence, some build tools, such as sbt, don't pull the libthrift jar
> itself.
> The pom should be be using a "jar" packaging, or even no packaging at all as
> "jar" is the default value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
