[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

[jeking3]

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1484#discussion_r164729591
  
    --- Diff: lib/php/lib/Factory/TStringFuncFactory.php ---
    @@ -21,8 +21,9 @@
     
     namespace Thrift\Factory;
     
    -use Thrift\StringFunc\Mbstring;
     use Thrift\StringFunc\Core;
    +use Thrift\StringFunc\Mbstring;
    --- End diff --
    
    In general fewer changes are better but in this case no, I don't care.  I 
do the same cleanup when I'm in files sometimes. :)


---