[
https://issues.apache.org/jira/browse/THRIFT-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742899#comment-16742899
]
Christoph Herold commented on THRIFT-3587:
------------------------------------------
Hi [~jensg]!
I've had a look at our code. We "patched" this outside of the Thrift component
in our code. I have now created a fork of the current version of Thrift and
implemented a simple patch by copying the relevant code from TSocket.cs to
TTLSSocket.cs. You can find the diff here:
[https://github.com/coeamyd/thrift/commit/28b57b92598af659deda9cc74d9cd885d3c7bbc1#diff-362d79cb3f945f52c3499b2a1bb6f578]
This is _*untested code*_! If you like, I can create a pull request, but
someone should actually test this, before it is added to the main repository.
Also, this code is currently a copy, and could therefore be consolidated to a
common implementation. If you like, I can also do this, but I probably won't be
allowed the time to thoroughly test the code.
I hope this helps!
Cheers,
Christoph
> C# TTLSSocket does not use timeout for opening the socket
> ---------------------------------------------------------
>
> Key: THRIFT-3587
> URL: https://issues.apache.org/jira/browse/THRIFT-3587
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.9.3
> Reporter: Christoph Herold
> Assignee: Jens Geyer
> Priority: Minor
> Labels: C#, TTLSSocket
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The {{TSocket}} class checks for a defined timeout when opening the socket
> connection and uses a ConnectHelper to perform the {{socket.Open()}} call
> with the defined timeout. The {{TTLSSocket}} class does not show this
> behavior. It simply calls {{Open}} without using timeout functionality. The
> code from {{TSocket}} can probably be reused as is in the {{TTLSSocket}}
> class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
