alisaifee opened a new pull request #2487:
URL: https://github.com/apache/thrift/pull/2487


   # Description
   When using the building functions for the fallback scenario in 
`ProtocolBase<Impl>::readBytes`, a `SystemError` is raised in python 3.10 (this 
was only a warning till python 3.9) due to the use of "#yi" for the output 
buffer argument. The removal of the warning and dropped support is described in 
[Python issue 40943: https://bugs.python.org/issue40943].
   
   Extra test cases have been added to cover serialization/deserialization both 
with compact & binary protocol both with and without the c-extension
   
   
   - [x] Did you create an 
[THRIFT-5488](https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-5488)
 ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern 
"THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but 
preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, 
did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere 
in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to