[
https://issues.apache.org/jira/browse/THRIFT-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5486.
--------------------------------
Resolution: Fixed
When yopu resolve (not close) please do it right
> fix issues found by spotbugs
> -----------------------------
>
> Key: THRIFT-5486
> URL: https://issues.apache.org/jira/browse/THRIFT-5486
> Project: Thrift
> Issue Type: Technical Debt
> Components: Java - Library
> Reporter: Bhalchandra Pandit
> Assignee: Bhalchandra Pandit
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Fixes the following issues found by spotbugs:
> Private method
> org.apache.thrift.partial.ThriftMetadata$ThriftPrimitive.getParentStruct() is
> never called
> Private method
> org.apache.thrift.TDeserializer.createNewStruct(ThriftMetadata$ThriftStruct)
> is never called
> org.apache.thrift.partial.PartialThriftComparer.areEqual(ThriftMetadata$ThriftMap,
> Object, Object, StringBuilder) makes inefficient use of keySet iterator
> instead of entrySet iterator
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
