alisaifee opened a new pull request #2499:
URL: https://github.com/apache/thrift/pull/2499


   Asserting on trying to deserialize None, or an invalid serialized buffer 
result in different exceptions being raised in python2 versus 3.
   
   These errors can be seen for example in [travis 
ci](https://app.travis-ci.com/github/apache/thrift/jobs/554567087#L5586).
   
   Removing these assertions since the tests were originally added to verify 
the compatibility issue with python 3.10 in #2487 and that fix can be verified 
by just asserting on passing an empty buffer. 
     
   
   - [x] Did you squash your changes to a single commit?  (not required, but 
preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, 
did you label the Jira ticket with "Breaking-Change"?
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to