+1 for dropping Py2 support On Fri, Jan 7, 2022 at 1:41 PM Duru Can Celasun <[email protected]> wrote:
> On Fri, 7 Jan 2022, at 21:27, Yuxuan Wang wrote: > > According to https://www.python.org/doc/sunset-python-2/, support for > > Python 2 was stopped from 2020-01-01, which is already more than two > years > > ago from now. Is there any reason that thrift should continue to support > > Python 2 in the newer versions? > > > > If there's no objections I would like to remove python 2 from CI > > configuration and docs (for example, LANGUAGES.md). > > > > If JIRA is a better place to discuss this than the maillist I can move > the > > discussion there as well. > > > > (This came up as we found out that a fix we did for Python 3 failed the > > Python 2 tests. That in itself is not a very big deal that we can make > the > > tests to work for both 2 and 3, but continuing support something that's > > already dropped by upstream for 2 years doesn't really make much sense to > > me.) > > +1 for dropping it. The wire formats have been stable for a very long time > and anyone who needs Python 2 support can stick to 0.15 without worrying > about compatibility. >
