[
https://issues.apache.org/jira/browse/THRIFT-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550694#comment-17550694
]
Hernan Silberman commented on THRIFT-4086:
------------------------------------------
I recently ran into this issue as well. I put together a quick project to
demonstrate the issue:
[https://github.com/nanreh/thrift_struct_refs]
> Java compiler generates different meta data depending on order of structures
> in file
> ------------------------------------------------------------------------------------
>
> Key: THRIFT-4086
> URL: https://issues.apache.org/jira/browse/THRIFT-4086
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.9.3, 0.10.0
> Reporter: Anton Batylin
> Priority: Major
>
> When compiling th following thrift code:
> {code}
> struct Customer {
> 1: required i32 customer_id,
> 2: required list<Order> orders
> }
> struct Order {
> 1: required i32 order_id,
> }
> {code}
> compiler generates meta data for {{orders}} field as {{FieldValueMetaData}}:
> {code}
> tmpMap.put(_Fields.ORDERS, new
> org.apache.thrift.meta_data.FieldMetaData("orders",
> org.apache.thrift.TFieldRequirementType.REQUIRED,
> new
> org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
>
> new
> org.apache.thrift.meta_data.FieldValueMetaData(org.apache.thrift.protocol.TType.STRUCT
> , "Order"))));
> {code}
> If structs order is reversed:
> {code}
> struct Order {
> 1: required i32 order_id,
> }
> struct Customer {
> 1: required i32 customer_id,
> 2: required list<Order> orders
> }
> {code}
> compiler generates meta data for {{orders}} field as {{StructMetaData}}:
> {code}
> tmpMap.put(_Fields.ORDERS, new
> org.apache.thrift.meta_data.FieldMetaData("orders",
> org.apache.thrift.TFieldRequirementType.REQUIRED,
> new
> org.apache.thrift.meta_data.ListMetaData(org.apache.thrift.protocol.TType.LIST,
>
> new
> org.apache.thrift.meta_data.StructMetaData(org.apache.thrift.protocol.TType.STRUCT,
> Order.class))));
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
