kou opened a new pull request, #2725:
URL: https://github.com/apache/thrift/pull/2725
<!-- Explain the changes in the pull request below: -->
Client: cpp
The current ThriftConfig.cmake isn't relocatable. It means that we can't
move ThriftConfig.cmake installed by "make install".
In general, users don't need to move ThriftConfig.cmake installed by "make
install" but some packaging systems such as conda and MSYS2 needs to move.
Because users of these packaging systems may use different prefix. For example,
conda may be used with ~alice/my-conda and ~bob/conda as base directory.
CMake has a feature to make Config.cmake relocatable:
https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html
We can use it to make ThriftConfig.cmake relocatable.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
