Jens-G opened a new pull request, #3000: URL: https://github.com/apache/thrift/pull/3000
* JensG: added testcase for THRIFT-5794 + reverted most of the changes ---- ### from https://github.com/apache/thrift/pull/2999: netstd: tests: also run tests with "net8" option of thrift-compiler Add a project which is a copy of the PublicInterfaces.Compile.Tests, but use the "net8" compiler option to generate code that uses C#12-features. Use the thrift-files from the existing test, to avoid code-duplication. This is effectively the tests that are run till v0.20.0. netstd: use default CSharp-language level of compiler instead of using Net8/C#12 for PublicInterfaces.Compile.Tests netstd: update readme for local building netstd: tests: include .exe extension, when looking for compiler It will not be found without this and causes na error and abort. netstd: tests: make MSBuild ignore errors when thrift-binary is not found and continue search Windows copmmand "where" errors when thrift-binary is not found in PATH. This will cause MSBuild to abort instead of searching in alternative paths. So just ignore potential erros and make it go on. Adapt this also for Unix "which", so we don't need to suppress the returncode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
