mhlakhani opened a new pull request, #3095:
URL: https://github.com/apache/thrift/pull/3095
<!-- Explain the changes in the pull request below: -->
This PR fixes the clang build (for the thrift compiler) and makes the Rust
build pass as well.
The C++ changes fix `inconsistent override` compiler warnings, and the Rust
change fixes a clippy warning about an unnecessary dereference.
I tested this with the below, which now passes (previously failed):
```
./configure --disable-dependency-tracking --without-python --without-ruby
--without-perl --without-py3 --without-swift --without-nodejs
make -j16
```
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
([Request account here](https://selfserve.apache.org/jira-account.html), **not
required for trivial changes**)
- [ ] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
