kpumuk opened a new pull request, #3270: URL: https://github.com/apache/thrift/pull/3270
<!-- Explain the changes in the pull request below: --> I am not yet quite sure what value does https://github.com/apache/thrift/pull/2223 bring, but since it was merged it is breaking `make -C lib/rb check`: * It uses `test-unit` library, while `lib/rb` only has RSpec — missing gem requirement * It tries to load `thrift` from global, while it is not installed This MR makes the tests pass for now. Other issues which I did not try to address are: * `test-unit` vs RSpec - why two testing libraries in the same project? I know `test-unit` is used for `test/rb`, but that is a separate project within the monorepo * code formatting is extremely off. Time to introduce automated linters? * Does it bring any value compared to existing specs? Not quite sure, the test suite is large, will need to compare <!-- We recommend you review the checklist/tips before submitting a pull request. --> - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [ ] Did you squash your changes to a single commit? (not required, but preferred) - [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. <!-- The Contributing Guide at: https://github.com/apache/thrift/blob/master/CONTRIBUTING.md has more details and tips for committing properly. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
