> On Nov. 4, 2014, 5:23 a.m., Lewis McGibbney wrote: > > Patch is looking good. I am testing
Yes @mattmann, the unit test passes for me - Vineet Ghatge ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27562/#review59728 ----------------------------------------------------------- On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27562/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2014, 5:17 a.m.) > > > Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, > and Vineet Ghatge Hemantkumar. > > > Bugs: tika-1423 > https://issues.apache.org/jira/browse/tika-1423 > > > Repository: tika > > > Description > ------- > > GRIB Parser Patch > > > Diffs > ----- > > ./trunk/tika-parsers/pom.xml 1636144 > > ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java > PRE-CREATION > > ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser > 1636144 > > ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java > PRE-CREATION > > ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 > UNKNOWN > > Diff: https://reviews.apache.org/r/27562/diff/ > > > Testing > ------- > > update for #27414 > > FYI for the life of me, I can't get the unit test to pass (was this working > for you @Vinegh?) > Patch is fully up to date with trunk and compiles at least. > > > Thanks, > > Chris Mattmann > >
