[ 
https://issues.apache.org/jira/browse/TIKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Allison updated TIKA-1501:
------------------------------
    Attachment: TIKA-1501-trunkv2.patch

This is a small modification of [~bobpaulin]'s patch.  This adds back in the 
second half of the test between regular service loading and OSGi for detectors.

It looks like when OSGi loads the DefaultDetector, the hierarchy is slightly 
different than the straight DefaultDetector.  OSGi's DefaultDetector has two 
children, a DefaultDetector and MimeTypes.  That child DefaultDetector appears 
to have the detectors that we'd expect.  In short, slightly different 
structure, but same algorithm will be applied...I think.

To confirm, Bob, the following lines reach outside of OSGi?

{noformat}
ServiceReference<Detector> detectorRef = bc.getServiceReference(Detector.class);
        DefaultDetector detectorService = 
(DefaultDetector)bc.getService(detectorRef);
{noformat}

Thank you, again.

If there are no objections, I'll apply this, and we'll have our OSGi tests back 
up and running!

> Fix the disabled Tika Bundle OSGi related unit tests
> ----------------------------------------------------
>
>                 Key: TIKA-1501
>                 URL: https://issues.apache.org/jira/browse/TIKA-1501
>             Project: Tika
>          Issue Type: Improvement
>          Components: packaging
>    Affects Versions: 1.6, 1.7
>            Reporter: Nick Burch
>         Attachments: TIKA-1501-trunk.patch, TIKA-1501-trunkv2.patch, 
> TIKA-1501.patch
>
>
> Currently, the unit tests for the Tika Bundle contain several bits like:
> {code}
> @Ignore // TODO Fix this test
> {code}
> We should really fix these unit tests so they work, and re-enable them



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to