[ 
https://issues.apache.org/jira/browse/TIKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642882#comment-14642882
 ] 

Konstantin Gribov commented on TIKA-1524:
-----------------------------------------

[[email protected]], it doesn't depend, since excluding {{junit}} from 
{{json-simple}} deps doesn't change anything from {{tika-bundle}} point. I 
don't see any non-test dependencies on junit in Tika project (via {{mvn 
dependency:tree -Dverbose=true}}), but it can leak through some deps marked as 
*provided* from {{maven-bundle-plugin}} point of view, I'm not so familiar with 
this plugin to be certain.

So, my +1 for inclusion of this patch with {{!org.junit.\*}} and {{!junit.\*}} 
to be sure that they are excluded in any case. I don't know why we have 
*explicitly* imported {{junit.textui}} with {{resolution=optional}} in 
tika-bundle's pom. If it's removed there will be no junit imports in 
{{Import-Package}} manifest section.

Also, I think that migration to one json library within Tika is good point. I 
personally prefer to use {{jackson}} but {{gson}} can be as good, so you can 
choose any of them if you'll migrate from json-simple. As I see neither 
tika-parsers nor tika-bundle depends on gson or jackson currently.

> Can install Tika-Bundle, missing JUnit dependency
> -------------------------------------------------
>
>                 Key: TIKA-1524
>                 URL: https://issues.apache.org/jira/browse/TIKA-1524
>             Project: Tika
>          Issue Type: Bug
>          Components: packaging
>    Affects Versions: 1.7
>         Environment: Karaf 2.3.6
>            Reporter: Niels
>         Attachments: TIKA-1524.patch
>
>
> When I'm trying to install a feature which has a dependency on the 
> Tika-Bundle, it fails to install. It indicates it's missing a dependency to 
> JUnit. 
> Momentarily I solved this for myself by reverting back to Tika-Bundle version 
> 1.6
> Error executing command: Could not start bundle 
> mvn:org.apache.tika/tika-bundle/1.7 in feature(s): Unresolved constraint in 
> bundle org.apache.tika.bundle [336]: Unable to resolve 336.0: missing 
> requirement [336.0] osgi.wiring.package; 
> (osgi.wiring.package=org.junit.internal)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to