[
https://issues.apache.org/jira/browse/TIKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055667#comment-16055667
]
Tim Allison edited comment on TIKA-2389 at 6/20/17 12:25 PM:
-------------------------------------------------------------
Draft patch. This would allow users to turn off warnings from parsers.
The idea is that there is a difference between a class loading error (class not
found/game over), which we currently handle well, and a potential problem that
1) the user should be warned of and/or 2) the user should be able to turn off.
Examples of this might include optional dependencies like the jbig2 issue that
launched this issue.
I added this functionality to the Initializable interface, and users can set
the global default in the service-loader element (e.g. {{<service-loader
initializableProblemHandler="throw"/>}}) and they can override it per
Initializable (e.g. {{<parser
class="org.apache.tika.parser.DummyInitializableParser"
initializableProblemHandler="info">}}.
I don't like the amount of code this adds, but it does differentiate between a
parser complaining at initialization time and parser complaining while
parsing...something a user couldn't do by setting the log level at the parser
level.
Recommendations?
was (Author: [email protected]):
Draft patch. This would allow users to turn off warnings from parsers.
The idea is that there is a difference between a class loading error, which we
currently handle well, and a potential problem that 1) the user should be
warned of and/or 2) the user should be able to turn off.
I added this functionality to the Initializable interface, and users can set
the global default in the service-loader element (e.g. {{ <service-loader
initializableProblemHandler="throw"/>}}) and they can override it per
Initializable (e.g. {{<parser
class="org.apache.tika.parser.DummyInitializableParser"
initializableProblemHandler="info">
}}.
I don't like the amount of code this adds, but it does cleanly(?) differentiate
between a parser complaining at initialization time and parser complaining
while parsing...something a user couldn't do by setting the log level at the
parser level.
Recommendations?
> Warn log level is pretty strong for missing JBIG2ImageReader
> ------------------------------------------------------------
>
> Key: TIKA-2389
> URL: https://issues.apache.org/jira/browse/TIKA-2389
> Project: Tika
> Issue Type: Wish
> Components: parser
> Affects Versions: 1.15
> Reporter: Thomas Mortagne
> Attachments:
> TIKA_2389____allow_configuration_for_warnings_in_Initializables.patch
>
>
> Given the license of jbig2-imageio many projects (Apache or LGPL projects for
> example) won't include it and will always end up with a warning because of it
> while they probably don't really care that much about this image format.
> Ideally ImageParser should probably be made more extensible and jbig2 part
> moved in an optional module but in the meantime is this warning that
> necessary ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
