stumpylog commented on code in PR #21:
URL: https://github.com/apache/tika-docker/pull/21#discussion_r1607058472
##########
docker-tool.sh:
##########
@@ -17,15 +17,24 @@
# specific language governing permissions and limitations
# under the License.
+stop_and_die() {
+ docker buildx stop tika-builder || die "couldn't stop builder -- make sure
to stop the builder manually! "
Review Comment:
I'm make this `docker buildx rm` instead. Just stopping it seems to have
the same effect, complaints about the existing instance
##########
docker-tool.sh:
##########
@@ -17,15 +17,24 @@
# specific language governing permissions and limitations
# under the License.
+stop_and_die() {
+ docker buildx stop tika-builder || die "couldn't stop builder -- make sure
to stop the builder manually! "
Review Comment:
I'd make this `docker buildx rm` instead. Just stopping it seems to have
the same effect, complaints about the existing instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
