On 19/06/2009, sebb <[email protected]> wrote:
> Just spotted this duplicate code in AccessLogValve:
>
>  661:                        if (!dateStamp.equals(tsDate)) {
>  662:                            if (!dateStamp.equals(tsDate)) {
>
>  Not sure this double-checked looking offers any benefit ;-)
>

Line 767 is also no longer needed, as currentMillis is now volatile:

765:        if ((systime - currentMillis) > 1000) {
766:            synchronized (this) {
767:                if ((systime - currentMillis) > 1000) {

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to