Author: markt
Date: Wed Mar 3 14:38:01 2010
New Revision: 918489
URL: http://svn.apache.org/viewvc?rev=918489&view=rev
Log:
Implement review feedback
Modified:
tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=918489&r1=918488&r2=918489&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Wed Mar 3
14:38:01 2010
@@ -1617,7 +1617,7 @@
containerLog.trace(" getRoles(" + dn + ")");
// Start with roles retrieved from the user entry
- ArrayList<String> list = user.roles;
+ List<String> list = user.roles;
if (list == null) {
list = new ArrayList<String>();
}
@@ -2218,21 +2218,21 @@
// ------------------------------------------------------ Private Classes
/**
- * A private class representing a User
+ * A protected class representing a User
*/
protected static class User {
- private String username = null;
- private String dn = null;
- private String password = null;
- private ArrayList<String> roles = null;
+ final private String username;
+ final private String dn;
+ final private String password;
+ final private List<String> roles;
- User(String username, String dn, String password,
- ArrayList<String> roles) {
+ protected User(String username, String dn, String password,
+ List<String> roles) {
this.username = username;
this.dn = dn;
this.password = password;
- this.roles = roles;
+ this.roles = Collections.unmodifiableList(roles);
}
public String getUserName() {
@@ -2248,7 +2248,7 @@
}
public List<String> getRoles() {
- return Collections.unmodifiableList(roles);
+ return roles;
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
