Simon Laws wrote:
On Tue, Oct 7, 2008 at 3:38 PM, Simon Nash <[EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
Simon Nash wrote:
Simon Laws wrote:
The release artifacts for the Tuscany SCA for Java 1.3.2
release are now available, please review and vote to release.
The artifacts are available for at:
http://people.apache.org/~slaws/tuscany/1.3.2-RC2/
<http://people.apache.org/%7Eslaws/tuscany/1.3.2-RC2/>
<http://people.apache.org/%7Eantelder/tuscany/1.3.1-RC1/>
This includes the signed binary and source distributions,
Maven staging repository, and eclipse update site and RAT
report.
The SVN tag for the release is:
<http://svn.apache.org/repos/asf/tuscany/tags/java/sca/1.3.1>http://svn.apache.org/repos/asf/tuscany/tags/java/sca/1.3.2-RC2/
Here's my +1
Simon
>
I built the source distro without any problems.
I tried running a selection of samples from the binary distro.
Unfortunately I didn't get very far before hitting the first
problem.
In samples/helloworld-jms-service, "ant run" gives the following
error:
Buildfile: build.xml
run:
[java] java.lang.NoClassDefFoundError:
helloworld/HelloWorldServer
[java] Caused by: java.lang.ClassNotFoundException:
helloworld.HelloWorldServer
[java] at
java.net.URLClassLoader$1.run(URLClassLoader.java:200)
[java] at
java.security.AccessController.doPrivileged(Native Method)
[java] at
java.net.URLClassLoader.findClass(URLClassLoader.java:188)
[java] at
java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[java] at
sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:276)
[java] at
java.lang.ClassLoader.loadClass(ClassLoader.java:251)
[java] at
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
[java] Exception in thread "main"
[java] Java Result: 1
BUILD SUCCESSFUL
Total time: 0 seconds
Despite the reassuring "BUILD SUCCESSFUL" message, something is
clearly
wrong with this picture. I looked at the build.xml file and it is
trying to call sample-helloworld-ws-service-jms.jar instead of the
correct filename sample-helloworld-service-jms.jar. Correcting this
allows the sample to run.
I'm withholding my +1 until I've had a chance to try more samples to
see how many of them have similar problems.
Simon
OK, I've run through the remaining samples, using ant and following
the README instructions. I found the following issues:
calculator-ws-webapp:
The sample runs, but the need to change the hardwired port in the
Calculator.composite file for installations that don't use port 8080
is a usability issue that needs to fixed. It should be possible to
create a WAR that can be deployed to different port numbers without
needing to be changed.
chat-webapp:
This can be built with ant as well as mvn, but the README only
describes
building it with mvn. The README should be updated to add a
description
of building it with ant.
domain-management:
README has no information on how to run the sample. There's a
build.xml
file but I couldn't work out what to do with the jars in the target
directory.
feed-aggregator-webapp:
The links in the browser page are displayed incorrectly with a
hard-wired
port of 8080. However, they do work when clicked, even though the
actual
port used by my Tomcat configuration is 8090.
helloworld-bpel:
Fails as already reported.
helloworld-bpel-ws:
Similar failure to helloworld-bpel. The build.xml file is identical to
that of helloworld-bpel. Is this correct?
helloworld-ws-sdo-webapp:
Same hardwired port problem as calculator-ws-webapp. It's worse in
this sample as the README gives no instructions on what change to
make to get around this.
implementation-notification:
"ant run" fails with the following stack trace:
[java] java.lang.NoClassDefFoundError:
notification/TrafficAdvisoryClient
[java] Caused by: java.lang.ClassNotFoundException:
notification.TrafficAdvisoryClient
[java] at java.net.URLClassLoader$1.run(URLClassLoader.java:200)
[java] at java.security.AccessController.doPrivileged(Native
Method)
[java] at
java.net.URLClassLoader.findClass(URLClassLoader.java:188)
[java] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[java] at
sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:276)
[java] at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
[java] at
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
This is caused by the jar file in the target directory not matching the
name in the build.xml file. The target directory jar has a
"-1.3.2" suffix
in its name and the build.xml file doesn't use this suffix. I
believe the
name in build.xml should be used, as this is consistent with how other
sample jars are named.
quote-xquery:
"ant run-server" produces a SEVERE error followed by a stack trace:
[java] 07-Oct-2008 15:16:58
org.apache.tuscany.sca.contribution.processor.ValidatingXMLStreamReader
[java] SEVERE: XMLSchema validation error occured in: null ,line
= 28, column = 5,
Message = cvc-complex-type.2.4.a: Invalid content was found
starting with element 'component'.
One of '{WC[##other:"http://www.osoa.org/xmlns/sca/1.0"]}' is
expected.
[java] 07-Oct-2008 15:16:58
org.apache.tuscany.sca.databinding.sdo.ImportSDOProcessor
[java] SEVERE: Fail to resolve class: xquery.quote.QuoteFactory
[java] Exception in thread "main"
org.osoa.sca.ServiceRuntimeException:
org.osoa.sca.ServiceRuntimeException: Fail to resolve class:
xquery.quote.QuoteFactory
[java] at
org.apache.tuscany.sca.host.embedded.SCADomain.createNewInstance(SCADomain.java:276)
[java] at
org.apache.tuscany.sca.host.embedded.SCADomain.newInstance(SCADomain.java:70)
[java] at
xquery.quote.XQueryQuoteServer.main(XQueryQuoteServer.java:28)
[java] Caused by: org.osoa.sca.ServiceRuntimeException: Fail to
resolve class: xquery.quote.QuoteFactory
[java] at
org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.analyseProblems(DefaultSCADomain.java:309)
[java] at
org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.addContribution(DefaultSCADomain.java:334)
[java] at
org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.init(DefaultSCADomain.java:186)
[java] at
org.apache.tuscany.sca.host.embedded.impl.DefaultSCADomain.<init>(DefaultSCADomain.java:120)
[java] at
org.apache.tuscany.sca.host.embedded.SCADomain.createNewInstance(SCADomain.java:242)
[java] ... 2 more
[java] Java Result: 1
The same SEVERE error is also produced by "ant run".
zipcode-jaxws:
There was along pause befaore any output was produced. I thought the
sample was hung or looping. It would be very helpful for the sample
to display "Please wait..." at the start to reassure people that all
is working as intended.
None of these problems is a showstopper, but the number of samples that
don't run adds up to a fairly poor user experience for someone new to
Tuscany working through the samples. As we are featuring 1.3.2 in our
Apache PR announcement, we are quite likely to get new users doing this.
However, I understand that there is a need to get the 1.3.2 release out
soon, so I won't stand in the way of this. My vote is +0.
I'll write JIRAs for the points above that don't already have JIRAs
raised for them.
Simon
Simon
Thanks for doing a comprehensive review. For me the quote-xquery does
work if I do ant compile before ant run so again either a fix to the
README and/or the build.xml file is required. I suspect you are also
picking up the fact that we tend to have the web servers that we test on
configured for 8080 which accounts for a few of your problems. A very
good point.
Simon
When I ran quote-xquery, I followed the README instructions which were to
do "ant" followed by "ant run-server". The "ant" command is equivalent
to "ant compile". We should look into why this worked for you and not
for me.
Simon
