I have started looking into the JavaScript issue you mentioned, but no success yet.
Some comments after some code review : - All files should have the Apache License headers as described in [1]... (I'm fixing this) - It would be good if you could provide some javaDoc comments describing the classes - It would be good if you could provide some javaDoc comments describing the interface methods and the private methods to help other better understand the meaning of the methods - You have couple interfaces mixed with the implementation package, it's probably better to refactor these classes to a different package - You should configure your IDE with the Tuscany code template and style [2][3] Well, this is all for now, I'll provide more comments after I get more familiar with the search functionaility. [1] http://www.apache.org/legal/src-headers.html#headers [2] https://svn.apache.org/repos/asf/tuscany/java/etc/tuscany-eclipse-codestyle.xml [3] https://svn.apache.org/repos/asf/tuscany/java/etc/tuscany-eclipse-codetemplates.xml On Sun, Aug 9, 2009 at 8:55 PM, Adriano Crestani<[email protected]> wrote: > Adriano, are you going to take a look at the patch ? Then, once it's > in SVN I could give this a try. > > It's already committed. It seems to be working as Phillipe described, so > give it a try :) > > On Sun, Aug 9, 2009 at 1:27 PM, Phillipe Ramalho > <[email protected]> wrote: >> >> Where are these special characters coming from ? >> The characters come from .composite and .xml files for now. Actually I >> think the result is broken because it contains these strange chars and not >> because it's too long. >> You are probably having issues with the scope/visibility of the js >> function and might need to prefix it with the proper iframe name or >> something similar. >> Do you know how to reference the function inside >> certain iframe? Something like iFrameX.search()? >> Phillipe, do I need any specific steps to get the search functionality >> enabled ? or it's already live in the Domain Manager UI ? >> It's already running when you start domain manager. Right now, if you >> restart the application you loose all the indexed data, that's why the first >> search takes longer, it's also indexing, it's defined like that for debug >> purposes. Actually there is no link yet to the search >> webpage, so, just type http://localhost:9990/ui/search to access the search webpage. >> >> On Sun, Aug 9, 2009 at 3:20 AM, Luciano Resende <[email protected]> >> wrote: >>> >>> On Sun, Aug 9, 2009 at 12:34 AM, Phillipe >>> Ramalho<[email protected]> wrote: >>> > Hello everyone, >>> > After one month, I finally got another big patch (just attached that to >>> > the >>> > TUSCANY-2552). >>> >>> Great, next time don't wait that long to get patches submitted, even >>> if you don't have everything working. Smaller patches makes it easier >>> for other to review and provide any feedback. >>> >>> > Problems: >>> > 1- there is a problem I have seen for a while but just ignored so far, >>> > when >>> > the results are too long, as I'm using atom binding to send the results >>> > back >>> > to the html javascript, the result get truncated when it's too long. >>> > Should >>> > I be using another binding? >>> >>> Why it's getting too long ? The search resultset if too long or >>> because you return pieces of the file returned by the search ? The >>> atom binding should support large feeds, we have been using it in the >>> feed aggregator sample to aggregate some large live feeds with no >>> issues. >>> >>> > 2- another problem which is probably related to the atom binding is it >>> > seems >>> > to not support some special characters. As I'm reading data from >>> > documents >>> > and indexing it, some strange character might get indexed, and there >>> > are >>> > some characters which causes some problem with the atom binding. Right >>> > now, >>> > as a workaround I'm removing every char in my results which is under >>> > 40, but >>> > I should probably be enconding that. What should I do? Is there any way >>> > to >>> > encode it, using some kind of escaper or should a switch to another >>> > binding >>> > technology? >>> >>> Where are these special characters coming from ? >>> >>> > 3- this is the last one that I hit this week, when I return the search >>> > results to the search-gadget webpage, it's html, and some part of it >>> > contains javascript calls to functions declared on search-gadget. >>> > However, >>> > the functions are not found when the browser tries to execute it, it >>> > says >>> > the function is not declared. Here is exactly what happens: there is a >>> > search.html which contains a iframe that loads search-gadget.html, >>> > search-gadget.html has a javascript function called getHighlighted(). >>> > When >>> > the user searches for something, the results are just html which is >>> > loaded >>> > into a div in search-gadget.html. This new result html loaded into this >>> > div >>> > contains a html component that calls getHighighlighted() when clicked, >>> > but >>> > this function is not found :(...any clue? >>> >>> You are probably having issues with the scope/visibility of the js >>> function and might need to prefix it with the proper iframe name or >>> something similar. >>> >>> Adriano, are you going to take a look at the patch ? Then, once it's >>> in SVN I could give this a try. >>> >>> Phillipe, do I need any specific steps to get the search functionality >>> enabled ? or it's already live in the Domain Manager UI ? >>> >>> >>> -- >>> Luciano Resende >>> Apache Tuscany, Apache PhotArk >>> http://people.apache.org/~lresende >>> http://lresende.blogspot.com/ >> >> >> >> -- >> Phillipe Ramalho > > -- Luciano Resende Apache Tuscany, Apache PhotArk http://people.apache.org/~lresende http://lresende.blogspot.com/
