[ 
https://issues.apache.org/jira/browse/TUSCANY-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990080#comment-12990080
 ] 

Mike Edwards commented on TUSCANY-3831:
---------------------------------------

The problem arises from the WSDLModelResolver in interface-wsdl.

The method loadDefinition(...) has code that deals with the case where the WSDL 
is referenced via a wsdli attribute - and in this case computes a URL for the 
artifact from the wsdli value.

However, at a point further down the method, the code attempts to access the 
WSDL file, not using the computed URL, but using a location value from the WSDL 
definition structure - which only has a value IF the WSDL has been loaded from 
a file contained within a contribution - which is NOT the case in this test 
(the test is deliberately using a URL which does not point to a file anywhere 
in any contribution...)

Map<String, String> wsdlImports = indexRead(wsdlDef.getLocation().toURL());

getLocation() returns NULL and this is the source of the NPE

The code should instead use the computed URL - which is derived from the wsdli 
value, if specified, or from the getLocation() value if there is no wsdli value 
(and note: if both wsdli & getLocation() are NULL, the code deal with the 
situation):


Map<String, String> wsdlImports = indexRead(artifactURL);


This version of the code committed in:

1066801

> Tuscany fails OASIS compliance test BWS_2016
> --------------------------------------------
>
>                 Key: TUSCANY-3831
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3831
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Axis Binding Extension
>    Affects Versions: Java-SCA-2.x
>            Reporter: Mike Edwards
>            Assignee: Mike Edwards
>             Fix For: Java-SCA-2.x
>
>
> Tuscany fails testcase BWS_2016.
> Basically, this test has a <binding.ws> element with a non-existent WSDL file 
> referenced via a wsdli attribute.  The test is expecting a failure with an 
> exception that spots that the WSDL file does not exist.  Instead, the code 
> fails with a NullPointerException - clearly not correct.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to