On Wed, Mar 30, 2011 at 1:42 PM, Luciano Resende <[email protected]> wrote: > On Tuesday, March 29, 2011, ant elder <[email protected]> wrote: >> On Wed, Mar 30, 2011 at 4:53 AM, Luciano Resende <[email protected]> >> wrote: >>> On Tue, Mar 29, 2011 at 4:05 PM, ant elder <[email protected]> wrote: >>>> There is something quite weird going on with this group of commits you >>>> just did, the svn history and diffs is all mixed up so you can't see >>>> whats going on, eg see this file which is a pom.xml turning into a >>>> java class. >>>> >>>> Did you do anything out of the ordinary with the commits? >>>> >>>> ...ant >>> >>> Basically git branch, commit, commit, git merge trunk... >>> The following seems very strange... >>> >>>> >>>> tuscany/sca-java-2.x/trunk/modules/node-api/src/main/java/org/apache/tuscany/sca/node/extensibility/NodeActivator.java >>>> - copied, changed from r1086614, >>>> tuscany/sca-java-2.x/trunk/modules/node-api/pom.xml >>>> >>>> tuscany/sca-java-2.x/trunk/modules/node-api/src/main/java/org/apache/tuscany/sca/node/extensibility/NodeActivatorExtensionPoint.java >>>> - copied, changed from r1086614, >>>> tuscany/sca-java-2.x/trunk/modules/node-api/pom.xml >>>> >>>> tuscany/sca-java-2.x/trunk/modules/node-api/src/main/java/org/apache/tuscany/sca/node/extensibility/NodeExtension.java >>>> - copied, changed from r1086614, >>>> tuscany/sca-java-2.x/trunk/modules/node-api/pom.xml >>> >>> But it seems that the files are ok in trunk. >>> >> >> But without diffs we can't see what was changed and the file history >> is lost so we can't see the provenance of the code. You need to fix >> this please Luciano. >> >> ...ant > > > What ??? These are new files and the only issue is that for some > reason Git or svn created a mail wrong... Come on Ant !!! >
It might be obvious to you what the changes are doing but thats because you made the changes, to others looking at these commit messages its hard to work out. Its committer 101 that commits are done in small discrete changes with descriptive log messages and without mixing multiple changes or formatting so that others can easily see whats going on and so its possible to work out historical changes from the svn history. If you know this was just a one off oversight or gremlin getting into your git tools then fine but if you don't know what went wrong then i think we need to sort it out so it doesn't continue happening. I'm happy to help you do that, perhaps we can talk to infra@ as i know there are others there who use git without these type of problems. ...ant
