Ok I've copied this to trunk but I think you should have just done that yourself, I certainly don't want to be the one tasked with coping each of the other samples back as people decided they want them. That is unless we decide to move all the old samples back, do people want to do that now? Personally I don't think we should.
As for the review comments, when you copied this to trunk before you didn't actually asked for any reviews which is probably why you didn't get them. Whether or not it matters now that we've gone back to the uncontrolled sample approach FWIW the main issues with it in my view are that its demonstrating bindings that we've said in 2.x would be deprecated and replaced by the rest binding, and that the shopping cart function doesn't work because its globally accessible instead of scoped to individual users which is the opposite of how a shopping cart should be and as thats the main point of the sample it doesn't seem ideal. Its also using an approach to the Ant build that (i thought) we'd all agreed we wouldn't use now and I think the README could do better at saying what the sample actually does, it doesn't really say at the moment but just points at old 1.x doc that doesn't apply to 2.x. IIRC all of these issues have been mentioned before. ...ant On Wed, Apr 6, 2011 at 4:38 AM, Luciano Resende <[email protected]> wrote: > Ant, as the only comments I got about the store sample [1] were that > it meets the requirements for releasing it, could you please move it > back to trunk and I'll continue to work on it. > > Thanks in Advance > > [1] http://tuscany.markmail.org/thread/afro3t4aamqa7jty > > On Tue, Mar 29, 2011 at 11:44 PM, <[email protected]> wrote: >> Author: antelder >> Date: Wed Mar 30 06:44:42 2011 >> New Revision: 1086858 >> >> URL: http://svn.apache.org/viewvc?rev=1086858&view=rev >> Log: >> Move the store app to unreleased >> >> Added: >> tuscany/sca-java-2.x/trunk/unreleased/samples/applications/ >> - copied from r1086854, tuscany/sca-java-2.x/trunk/samples/applications/ >> >> > > > > -- > Luciano Resende > http://people.apache.org/~lresende > http://twitter.com/lresende1975 > http://lresende.blogspot.com/ >
