On Thu, Jun 16, 2011 at 2:31 AM, Brent Daniel <[email protected]> wrote: > I noticed that the appliesTo processing in PolicyAppliesToBuilderImpl > is not operating on components. Otherwise it seems to be working fine > from what I can tell. This is something to take into consideration if > the implementation policies are moved back to the component, though. > The appliesTo would happen after the policy set was moved to the > component, so if the builder was correctly handling components, any > implementation policy set that had a reasonably specific appliesTo > would be removed. For example, the ManagedTransactionPolicySet applies > to elements that start with "implementation", so it would be removed. > > Brent
You're right Brent. Currently the appliesTo process assumes that the policies for an implementation are retained on the implementation model. If we do resort to holding them on the component then we will have to take the set on the component into account when calculating appliesTo. The bottom line is that we have some code that assumes policy sets are on the implementation and some that assumes they are on the component. If we use the implementation then we loose the shared implementation optimization. If we use the component then we have to fix applies to etc. At the moment it looks like most of the code assumes it's on the component so, as I said, I'll first take and approach of putting them back on the component and see if I can get that path working again. I I struggle I'll look at unpicking the shared implementation assumption. Simon -- Apache Tuscany committer: tuscany.apache.org Co-author of a book about Tuscany and SCA: tuscanyinaction.com
