On Wed, Jun 29, 2011 at 3:41 AM, Guilherme Armigliatto
<[email protected]> wrote:
> Hi,
>
> I have created the basic structure of the module implementation.scala, that
> is based in the implementation.script. I need to review the maven
> dependencies, since I just copy the pom.xml from imp.script, and change some
> things. I create an issue at JIRA [1] and attached the source.
>
> [1] https://issues.apache.org/jira/browse/TUSCANY-3891
>
>
> Thanks,
> Guilherme.
>
> ---
> Guilherme Moraes Armigliatto
> Master Degree Student
> Reasoning for Complex Data (RECOD)
> Institute of Computing (IC), University of Campinas (UNICAMP)
> Campinas, SP, Brazil
>
>
Hi Guilherme
Thanks for the patch. I realize this is just a framework for your code
so a couple of non-technical notes:
implementation-scala
=================
- We don't tend to check in the Eclipse project files as they can be
generated using "mvn eclipse:eclipse". I've omitted them from the code
- Apache headers are missing from the following files (I've added them)
ScalaImplementationProcessor.java
- We don't check in target directories because they are generated by
the maven build. I've omitted them
- The LICENSE/NOTICE files contain some BSD clauses from
implmentation.script. I've removed them but we do need to consider if
there are clauses we need to add relating to Scala licensing
implementation-scala-runtime
=======================
- same comments as before re. no needing to check in Eclipse files or
the target directory
- Apache headers are missing from the following files (I've added them)
ScalaImplementationProvider.java
ScalaImplementationProviderFactory.java
I've gone ahead and checked the files in (at revision: 1141219) so
that you can work of this framework now and continue to create patches
as you make progress. Be careful to add Apache headers as appropriate
when you create new files. If, for what ever reason, you need to
include any code from Scala either for runtime integration or for
testing that will likely require it's own attribution so be sure to
call that out if you get to that situation.
Regards
Simon
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com
