Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/165#discussion_r25743662
  
    --- Diff: 
stack/core/src/main/java/org/apache/usergrid/corepersistence/CpWalker.java ---
    @@ -58,8 +58,10 @@ public CpWalker(){
         public void walkCollections(final CpEntityManager em, final EntityRef 
start,
             String collectionName, boolean reverse, final CpVisitor visitor) 
throws Exception {
     
    -        doWalkCollections(
    -            em, collectionName, reverse, new SimpleId( start.getUuid(), 
start.getType() ), visitor );
    +        if(start != null) {
    --- End diff --
    
    Should we fail silently or blow up here?  Feels like we should do 
preconditions so we can flush out the incorrect caller impl


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to