Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/199#discussion_r27404863
--- Diff:
stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/migration/EsIndexDataMigrationImpl.java
---
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.usergrid.persistence.index.migration;
+
+import com.google.inject.Inject;
+import org.apache.usergrid.persistence.core.migration.data.DataMigration;
+import
org.apache.usergrid.persistence.core.migration.data.MigrationDataProvider;
+import
org.apache.usergrid.persistence.core.migration.data.ProgressObserver;
+import org.apache.usergrid.persistence.core.migration.data.VersionedData;
+import org.apache.usergrid.persistence.core.scope.ApplicationScope;
+import org.apache.usergrid.persistence.index.AliasedEntityIndex;
+import org.apache.usergrid.persistence.index.IndexFig;
+import org.apache.usergrid.persistence.index.IndexIdentifier;
+import org.apache.usergrid.persistence.index.IndexCache;
+import org.apache.usergrid.persistence.index.impl.EsProvider;
+import
org.elasticsearch.action.admin.indices.alias.IndicesAliasesRequestBuilder;
+import org.elasticsearch.client.AdminClient;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import rx.Observable;
+
+/**
+ * Classy class class.
+ */
+public class EsIndexDataMigrationImpl implements
DataMigration<ApplicationScope> {
+
+ private final AliasedEntityIndex entityIndex;
+ private final EsProvider provider;
+ private final IndexFig indexFig;
+ private final IndexIdentifier indexIdentifier;
+ private final IndexCache indexCache;
+ private final VersionedData dataVersion;
+ private static final Logger log =
LoggerFactory.getLogger(EsIndexDataMigrationImpl.class);
+
+ @Inject
+ public EsIndexDataMigrationImpl(AliasedEntityIndex entityIndex,
EsProvider provider, IndexFig indexFig, IndexIdentifier indexIdentifier,
IndexCache indexCache){
+ this.entityIndex = entityIndex;
+ this.provider = provider;
+ this.indexFig = indexFig;
+ this.indexIdentifier = indexIdentifier;
+ this.indexCache = indexCache;
+ this.dataVersion = (VersionedData) entityIndex;
+ }
+
+ @Override
+ public int migrate(int currentVersion,
MigrationDataProvider<ApplicationScope> migrationDataProvider, ProgressObserver
observer) {
+ final AdminClient adminClient = provider.getClient().admin();
+ final int latestVersion = dataVersion.getImplementationVersion();
+
+ observer.start();
+ migrationDataProvider.getData().flatMap(applicationScope -> {
+ LegacyIndexIdentifier legacyIndexIdentifier = new
LegacyIndexIdentifier(indexFig, applicationScope);
+ String[] indexes =
indexCache.getIndexes(legacyIndexIdentifier.getAlias(),
AliasedEntityIndex.AliasType.Read);
+ return Observable.from(indexes);
+ })
+ .doOnNext(index -> {
+ IndicesAliasesRequestBuilder aliasesRequestBuilder =
adminClient.indices().prepareAliases();
+ aliasesRequestBuilder =
adminClient.indices().prepareAliases();
+ // add read alias
+ aliasesRequestBuilder.addAlias(index,
indexIdentifier.getAlias().getReadAlias());
+ observer.update(latestVersion,"EsIndexDataMigrationImpl:
fixed index: " + index );
+ })
+ .doOnError(error -> {
--- End diff --
Lets only catch + swallow exceptions we expect. Otherwise this will fail
silently and the migration with succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
