Github user GERey commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/232#discussion_r28733615
  
    --- Diff: 
stack/rest/src/test/java/org/apache/usergrid/rest/test/resource2point0/endpoints/CollectionEndpoint.java
 ---
    @@ -219,58 +224,58 @@ public ApiResponse delete(final QueryParameters 
parameters, final boolean useTok
          * POST /users {"color","red"}
          * </pre>
          */
    -    public Entity post(Entity payload){
    -
    -        String acceptHeader = MediaType.APPLICATION_JSON;
    -        if (this.acceptHeaders.size() > 0) {
    -            acceptHeader = StringUtils.join(this.acceptHeaders, ',');
    -        }
    -
    -        // use string type so we can log actual response from server
    -        String responseString = getResource(true)
    -            .type( MediaType.APPLICATION_JSON_TYPE )
    -            .accept(acceptHeader)
    -            .post(String.class, payload);
    -
    -        logger.debug("Response from post: " + responseString);
    -
    -        ObjectMapper mapper = new ObjectMapper();
    -        ApiResponse response;
    -        try {
    -            response = mapper.readValue( new StringReader(responseString), 
ApiResponse.class);
    -        } catch (IOException e) {
    -            throw new RuntimeException("Error parsing response", e);
    -        }
    -
    -        return new Entity(response);
    -    }
    -
    -    public Entity post() {
    -
    -        String acceptHeader = MediaType.APPLICATION_JSON;
    -
    -        if (this.acceptHeaders.size() > 0) {
    -            acceptHeader = StringUtils.join(this.acceptHeaders, ',');
    -        }
    -
    -        // use string type so we can log actual response from server
    -        String responseString = getResource(true)
    -            .type( MediaType.APPLICATION_JSON_TYPE )
    -            .accept(acceptHeader)
    -            .post(String.class);
    -
    -        logger.debug("Response from post: " + responseString);
    -
    -        ObjectMapper mapper = new ObjectMapper();
    -        ApiResponse response;
    -        try {
    -            response = mapper.readValue( new StringReader(responseString), 
ApiResponse.class);
    -        } catch (IOException e) {
    -            throw new RuntimeException("Error parsing response", e);
    -        }
    -
    -        return new Entity(response);
    -    }
    +//    public Entity post(Entity payload){
    --- End diff --
    
    You could delete this. No point in having it hanging around :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to