Hi Isura, Checked the git pull request and there are some code formatting issues. Example: line 151 in HybridRoleManager.java .
Regards, Nira On Fri, Dec 5, 2014 at 3:35 PM, Isura Karunaratne <[email protected]> wrote: > Hi Sameera, > > I have created the pull request [1] and attached a new diff to the jira[2] > with fixing formatting issues. > > > [1] https://github.com/wso2/carbon4-kernel/pull/115 > [2] https://wso2.org/jira/browse/IDENTITY-2911 > <https://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fjira%2Fbrowse%2FIDENTITY-2911&sa=D&sntz=1&usg=AFQjCNFiO7c6GSsKvjnyd9xXAK566y_XEA> > Thanks. > Isura. > > On Thu, Dec 4, 2014 at 1:42 PM, Sameera Jayasoma <[email protected]> wrote: > >> Also there are some formatting issues in this patch it seems. Please fix >> them and let us know. >> >> On Thu, Dec 4, 2014 at 1:41 PM, Sameera Jayasoma <[email protected]> >> wrote: >> >>> Reminder!!!! We need the PR to commit.. >>> >>> On Wed, Dec 3, 2014 at 4:45 PM, Sameera Jayasoma <[email protected]> >>> wrote: >>> >>>> Hi Isura, >>>> >>>> Can you send PR to the master branch of kernel git repository? >>>> >>>> Thanks, >>>> Sameera. >>>> >>>> On Wed, Dec 3, 2014 at 3:54 PM, Isura Karunaratne <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please commit following >>>>> >>>>> https://wso2.org/jira/browse/IDENTITY-2911 >>>>> <https://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fjira%2Fbrowse%2FIDENTITY-2911&sa=D&sntz=1&usg=AFQjCNFiO7c6GSsKvjnyd9xXAK566y_XEA> >>>>> >>>>> >>>>> Thanks >>>>> Isura. >>>>> >>>>> -- >>>>> Isura Dilhara Karunaratne >>>>> Software Engineer >>>>> >>>>> Mob +94 772 254 810 >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Sameera Jayasoma, >>>> Software Architect, >>>> >>>> WSO2, Inc. (http://wso2.com) >>>> email: [email protected] >>>> blog: http://sameera.adahas.org >>>> twitter: https://twitter.com/sameerajayasoma >>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>>> Mobile: 0094776364456 >>>> >>>> Lean . Enterprise . Middleware >>>> >>>> >>> >>> >>> -- >>> Sameera Jayasoma, >>> Software Architect, >>> >>> WSO2, Inc. (http://wso2.com) >>> email: [email protected] >>> blog: http://sameera.adahas.org >>> twitter: https://twitter.com/sameerajayasoma >>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>> Mobile: 0094776364456 >>> >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> Sameera Jayasoma, >> Software Architect, >> >> WSO2, Inc. (http://wso2.com) >> email: [email protected] >> blog: http://sameera.adahas.org >> twitter: https://twitter.com/sameerajayasoma >> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >> Mobile: 0094776364456 >> >> Lean . Enterprise . Middleware >> >> > > > -- > Isura Dilhara Karunaratne > Software Engineer > > Mob +94 772 254 810 > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
