Hi Manoj, Yes you are correct, but will that be ok to change package names since this may be already used in many other locations?. So if we change package structure that may cause many other problems. Besides, if we export packages explicitly as done in above mentioned pull requests, won't that solve the issue?(In osgi we can resolve it like that AFAIK)
Thanks, On Tue, Jul 7, 2015 at 4:23 AM, Manoj Kumara <[email protected]> wrote: > Hi Rajith, > > The normal pattern that we use for service stubs like org.wso2.carbon.xxx.stub > not ui.stub. Since there is another module with org.wso2.carbon.xxx.ui > with this commit there can be pacage level conflicts. So better to fix this > properly. > > Regards, > Manoj > > > *Manoj Kumara |* Senior Software Engineer > Inc. *| **lean. enterprise. middleware.* > #20, Palm Grove, Colombo 03, Sri Lanka > *Mobile:* +94 713 448188 *|** Work:* +94 112 145345 > > > On Fri, Jul 3, 2015 at 12:50 AM, Rajith Vitharana <[email protected]> > wrote: > >> Hi, >> >> Both fixes should be there right? unless ui.stub packages will be >> exported by both stub component and ui component. >> >> Thanks, >> >> On Fri, Jul 3, 2015 at 10:58 AM, Ravi Undupitiya <[email protected]> wrote: >> >>> Hi All, >>> >>> There's a class loading issue affecting ESB described in [1]. This has >>> happened due to changes in [2]. >>> >>> We can fix this issue using [3] however kernel team suggests the fix in >>> [2] breaks the package naming convention used as per other UI stubs. @Manoj >>> has more details on this. >>> >>> Please advise whether we should go ahead with fix in [3]. >>> >>> >>> [1] https://wso2.org/jira/browse/ESBJAVA-3734 >>> [2] >>> https://github.com/wso2/carbon-commons/commit/3cb5ee0b3f3086fb0e300e2bae7a91f7b365f197 >>> [3] https://github.com/wso2/carbon-commons/pull/103/files >>> >>> >>> >>> Thanks, >>> -- >>> *Ravi Undupitiya* >>> Senior Software Engineer; WSO2 http://wso2.com >>> >>> >>> *E-mail: [email protected] <http://wso2.com>**M: **+94 772 930 712 >>> <%2B94%C2%A0772%20930%20712>* >>> >>> Lean . Enterprise . Middleware >>> >> >> >> >> -- >> Rajith Vitharana >> >> Software Engineer, >> WSO2 Inc. : wso2.com >> Mobile : +94715883223 >> Blog : http://lankavitharana.blogspot.com/ >> > > -- Rajith Vitharana Software Engineer, WSO2 Inc. : wso2.com Mobile : +94715883223 Blog : http://lankavitharana.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
