On 10/19/13 3:59 AM, Axel Hecht wrote:
Hi David,
that's great news.
I'm wondering though, should we make a reduced keyboard set opt-in
rather than opt-out?
The immediate impetus for landing this is that the full set of keyboards
was too big for some our devices and it was breaking OTA updates. It
seems to me that the default build should be too big for any devices are
going to ship on. Also, I imagine that every one of our partners will
want to customize the layouts they ship with to the geographical region
they're serving. It would be weird if phones sold in Latin America had
layouts and dictionaries for Eastern Europe, for example. My thought was
that partners will specify the set of keyboard layouts they want at the
same time in their build process that they specifiy the set of supported
languages.
Having said that, I'm not commited to opt-in. My immediate interest was
to just stop breaking the builds. Now that we have a customization
framework in place for this, it is trivial to change the default set of
keyboards, and shouldn't be to hard to default to "all the keyboards".
In particular, on 1.2, I'm concerned about partners not getting the
message until very late in the game, and then starting all kind of
crunch panic.
I agree, but don't really have any idea how to get the word out there.
How do we spread the word about this? Maybe the multi-locale docs can
mention the keyboard customization?
Also, is there an option for "gimme all them keyboards!"?
No there is not. One could be added with a little work. (Ideally by
someone who knows more about our build scripts than I do :-). One of
the things I like about this customizability, however, is that it allows
contributors to add layouts freely to the gaia/keyboard/layouts/
directory. If these contributed layouts become part of the build by
default, then we'll want to vet them carefully when they are
contributed. But if they require opt-in at build time, then we can
easily just accept any contributions.
David
Axel
On 10/18/13 10:42 PM, David Flanagan wrote:
I've just landed bug 884752 to master, and will be working to get it
uplifted to 1.2 soon. If you are in QA or automation or release
engineering and you need to produce Gaia builds, you should read the
rest of this message.
This patch allows the set of keyboard layouts and autocorrect
dictionaries to be specified at build time, and is necessary because we
had put so many dictionaries into the default build that we were running
out of space on some devices.
These two lines in the Makefile specify the default layouts:
# This variable is for customizing the keyboard layouts in a build.
GAIA_KEYBOARD_LAYOUTS?=en,pt-BR,es,de,fr,pl
This was my best guess and what a minimal set of keyboard layouts should
be. To create a build that includes other layouts, just specify this
environment variable when building:
GAIA_KEYBOARD_LAYOUTS=en,es,fr,zh-Hans-Pinyin make install-gaia
The set of available layouts is now in $GAIA/keyboard/layouts/ And the
dictionaries required by those layouts are in
$GAIA/keyboard/dictionaries. At build time, the necessary files are
copied to apps/keyboard/js/layouts/ and
apps/keyboard/js/imes/latin/dictionaries. The .gitignore file has been
modified to ignore these files that are copied into place at build time.
If you have any trouble creating builds or using the keyboard in the
coming days and think it is related to this change, please let me know.
David
_______________________________________________
dev-gaia mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-gaia
_______________________________________________
dev-b2g mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-b2g
