Le 12/03/2014 15:54, 黃強(shawnjohnjr) a écrit : > There is a follow-up bug 980899 > <https://bugzilla.mozilla.org/show_bug.cgi?id=980899>. I've informed the > owner already. > Please remove patch Update-callbacks-to-match-bluetooth.h.patch > <https://www.codeaurora.org/cgit/quic/lf/b2g/build/tree/patch/all/gecko/Update-callbacks-to-match-bluetooth.h.patch> > before > they updated repository. > As far as I know, this patch was added only in master branch (from caf) > instead of 1.3 branch.
My tree was previously on master, I switched back to v1.3 by doing a BRANCH=v1.3 config.sh hamachi > > See: https://www.codeaurora.org/cgit/quic/lf/b2g/build/tree/ > > On Wed, Mar 12, 2014 at 4:11 PM, Alexandre Lissy <[email protected] > <mailto:[email protected]>> wrote: > > This also seems to prevent from building 1.3 which I need to fix > voicemail notification. > > Marco Chen a écrit: > >>> It's not a good way to patch gecko code> I agree with Shawn. > > And for my experience, I had tried to propose the "patch" > mechanism and reviewer strongly rejected it. > > The reason is that "all patch should be reviewed well then commit > into repository" > > Then I kept this principle when I reviewed other devices manifest. > > > > If this is a case we allowed then I can't say no for following > requests from partner. > > Do we allow it? > > > > ----- 原始郵件 ----- > > 寄件者: "Shawn Huang" <[email protected] > <mailto:[email protected]>> > > 收件者: [email protected] <mailto:[email protected]> > > 寄件備份: 2014 3 月 8 星期六 上午 12:37:43 > > 主旨: Re: [b2g] Master hamachi build failure> On Saturday, March > 1, 2014 12:19:06 AM UTC+8, Shawn Huang wrote:>> On Friday, February > 28, 2014 11:09:48 PM UTC+8, Sotaro Ikeda wrote: > >> > >> I don't know why. Since hamachi is ICS based and still uses bluez > as the bluetooth stack. This patch is not necessary for hamachi, now > only JB/KK uses bluedroid as the bt stack. I think you can delete > the patch locally. It looks like caf has their own modification for > bluetooth HAL header files, and since we followed AOSP bluetooth HAL > (at least I think we shall follow aosp HAL), caf tries to patch our > gecko code to match their HAL headers. Auto patch failed because > recently change file path in bug 972732.> It's not a good way to > patch gecko code, especially HAL headers changed and patches are > under device/qcom/b2g_common/patch/all/gecko. How do we handle this > kind of HAL changes? Can anyone please enlighten me? How do we > choose to support AOSP HAL or CAF HAL? > > _______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
