Seconding Kyle here. I did announce settings before it landed, it got backed out due to the Mnw and other breakage, took a week to come back in. At that point we were still clearing tbpl, but there were lots of usage issues with the phone. Not only that, since it was a underlying API that lots of things hit, it also canary'd issues with Marionette/IDB/Nuwa/etc. There were also issues with the reasons this API landed like it did (it rotted in review queues for months, followed by last minute 2.1 crashland).
So, yes, lots of testing is good, backing out is good, but don't act like our testing/regression systems are anywhere near complete, ESPECIALLY for APIs that can really only be exercised in an OOP context where we can have processes crashing, OOM'ing, etc. We haven't been able to run OOP b2g desktop tbpls for months, I can't even open an app in b2g desktop oop as of last week, etc. I know lightsofapollo is working on this, but we've got a ways to go before we're stable on this. Maybe we should run an even earlier landing schedule for large API changes so we don't have last minute crashlands like this, either. We found out this was due 3 weeks before FL, no one pushed back, but now we all complain about lack of tests. I've seen multiple APIs land like this now, so while better verification is great, it can only go so far. ----- Original Message ----- > From: "Kyle Huey" <[email protected]> > To: "Jonas Sicking" <[email protected]> > Cc: "Julien Wajsberg" <[email protected]>, "dev-b2g" > <[email protected]> > Sent: Friday, September 26, 2014 10:23:28 AM > Subject: Re: [b2g] Please announce your big potentially breaking changes on > the list > > On Fri, Sep 26, 2014 at 9:40 AM, Jonas Sicking <[email protected]> wrote: > > On Thu, Sep 18, 2014 at 6:31 AM, Julien Wajsberg <[email protected]> > > wrote: > >> So if you know your changes can cause ugly regressions accross the whole > >> platform, it's a good idea to say it in advance :) > > > > Also, do a whole lot of testing before checking something like that in. > > > > Checking in a patch that breaks stuff, even just a little and even > > just for a couple of days, has a very huge cost in terms of reduced > > productivity for everyone else. > > > > If anyone sees patches go in that break things, back it out, reopen > > the bug, and leave a comment about what was broken. > > > > / Jonas > > _______________________________________________ > > dev-b2g mailing list > > [email protected] > > https://lists.mozilla.org/listinfo/dev-b2g > > Unfortunately it's quite difficult to do a thorough job testing > because there is a lot of testing that does not run on tryserver. :/ > > - Kyle > _______________________________________________ > dev-b2g mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-b2g > _______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
