Have you put any thought into security permissions in this work? IE making the various channels safer so they can be exposed to third party apps (privileged, or maybe even hosted)? Specifically, moz-audio-channel-telephony & moz-audio-channel-ringer for which are permission exposed just for loop since we know that it will play nice with the dialer. It would be nice if we implemented safe logic that prioritised gaia apps such that we could safely support the use cases like loop, without having to rely on the behaviour of third-party apps to ensure that calls were not interupted/prevented. Maybe this is a goal, but it was a little unclear from the spec if the approach required co-operation between dialer/telephony apps.
Some other questions from the spec (I’m referring to the last page): - How do we prevent telephony calls from being interrupted by content? If I understand the last page, it says if there is telephony playing, and audio comes at the content level, the response will be "PLAY both the current and the new channels”. Is there some other assumption here, like audio can’t start in the background? (I note that in the reverse case, when content is playing and call comes in, the content audio is paused). - Does this proposal completely replace the previous approach where priority was given to audio with a higher channel? Thanks, Paul > On 6 Mar 2015, at 12:06 pm, Dominic Kuo <[email protected]> wrote: > > Hi Gabrieie, > > On Thu, Mar 5, 2015 at 9:04 PM, Gabriele Svelto <[email protected] > <mailto:[email protected]>> wrote: > I've chopped out all the audio channel hacks in the dialer / callscreen > / emergency-call apps recently. All the bits have already landed though, > do I still need to make the bugs blocking bug 1139838 purely for > dependency purposes? (i.e. if we want to uplift this stuff to something > older than v3) > > Gabriele > > > It will be nice to record those fixed bugs that removed the audio channels > hacks > because we can know how the hacks are removed, or probably they are wrong > fixes > and we should use a proper one. > > The new audio channel management does not change the current api usage in > gaia, > it's a platform work which we move the implementation from gecko to gaia, so > for all > the gaia apps: > > 1. Adding the audio channel permission in manifest.webapp. > 2. Setting the |mozAudioChannelType| for the media element. > 3. (Optional) listen to media element's |mozinterruptbegin| and > |mozinterruptend| if app > needs some ui interactions. > > are still the only necessaries, that means, anything besides these two/three > operations > are all hacks, I would expect a correct fix does not contain new logic and > simply clean > the unnecessary code. > > Thanks, > - Dominic > _______________________________________________ > dev-gaia mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-gaia
_______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
