On Monday 2015-07-27 12:03 -0700, Naoki Hirata wrote: > The dev knew about the crash locally: > https://bugzilla.mozilla.org/show_bug.cgi?id=1186965#c24 > So shouldn't that prevent him from landing in the first place if he's > crashing locally?
That comment was from after the regression was found, not before. Developers are not responsible for manually testing things across multiple devices and platforms unless there's particular reason to think that such testing is needed (e.g., because the change has platform-specific or device-specific code). The underlying problem here is that it's relatively easy to have a build that we consider unacceptable for our nightly users that still passes all of our automated tests. (In this case that appears to be because we're only running Firefox OS mochitests on top of Android ICS, which isn't what we're shipping to our nightly users.) If the automated test coverage covered most of the things that we consider essential for our nightly users, as it does for Firefox, we'd be much less likely to have these problems. And people doing backouts are still responsible for backing out changes correctly, and in a way that doesn't break other tests. -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla https://www.mozilla.org/ 𝄂 Before I built a wall I'd ask to know What I was walling in or walling out, And to whom I was like to give offense. - Robert Frost, Mending Wall (1914)
signature.asc
Description: Digital signature
_______________________________________________ dev-b2g mailing list [email protected] https://lists.mozilla.org/listinfo/dev-b2g
