It definitely should have stated +/-: fd: make fd/fp mandatory in falloc I don't know how I dropped that part, it was reshuffled from a bigger patchset.
On 1/8/21, John Baldwin <[email protected]> wrote: > On 1/7/21 3:30 PM, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=20ac5cda965eccc34f975674c6efc97c3615a234 >> >> commit 20ac5cda965eccc34f975674c6efc97c3615a234 >> Author: Mateusz Guzik <[email protected]> >> AuthorDate: 2020-12-23 13:50:34 +0000 >> Commit: Mateusz Guzik <[email protected]> >> CommitDate: 2021-01-07 23:30:04 +0000 >> >> fd: make fd/fp mandatory >> >> They are both always passed anyway. > > Perhaps say which part of the API this affects (seems to be falloc*() from > the diff?) next time? As it reads now, the log implies it applies to all > functions in the file descriptor API which can't possibly be true (fdrop > doesn't take 'fd' for example). > > -- > John Baldwin > -- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all To unsubscribe, send any mail to "[email protected]"
