The branch stable/13 has been updated by kbowling (ports committer):

URL: 
https://cgit.FreeBSD.org/src/commit/?id=6bf001dfe549e3838a15e2f01a5e649b6a0be41d

commit 6bf001dfe549e3838a15e2f01a5e649b6a0be41d
Author:     Guinan Sun <[email protected]>
AuthorDate: 2020-07-09 08:00:41 +0000
Commit:     Kevin Bowling <[email protected]>
CommitDate: 2021-09-14 00:36:47 +0000

    ixgbe: improve log about autoneg being disabled
    
    On ESXi OS, when user disables auto negotiation, the following log
    appears: "(unsupported) Flow control autoneg is disabled".
    It is true that auto negotiation is disabled but it is
    not necessarily true that it is not supported.
    
    Signed-off-by: Jakub Chylkowski <[email protected]>
    Signed-off-by: Guinan Sun <[email protected]>
    Reviewed-by: Wei Zhao <[email protected]>
    
    Approved by:    imp
    Obtained from:  DPDK (ab6ac48d483ef7f906b90f45182f2ddf3254d876)
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D31621
    
    (cherry picked from commit f511cd22586a9c0358b86334a51e3db60ca2db01)
---
 sys/dev/ixgbe/ixgbe_common.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sys/dev/ixgbe/ixgbe_common.c b/sys/dev/ixgbe/ixgbe_common.c
index 92db7c14da45..34c0f128aae4 100644
--- a/sys/dev/ixgbe/ixgbe_common.c
+++ b/sys/dev/ixgbe/ixgbe_common.c
@@ -3118,8 +3118,9 @@ void ixgbe_fc_autoneg(struct ixgbe_hw *hw)
         * - link is not up.
         */
        if (hw->fc.disable_fc_autoneg) {
-               ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,
-                            "Flow control autoneg is disabled");
+               /* TODO: This should be just an informative log */
+               ERROR_REPORT1(IXGBE_ERROR_CAUTION,
+                             "Flow control autoneg is disabled");
                goto out;
        }
 
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to