The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=6776747a0e0b1c0e3fb916685ac2180ca4ce2f3d
commit 6776747a0e0b1c0e3fb916685ac2180ca4ce2f3d Author: Konstantin Belousov <[email protected]> AuthorDate: 2021-10-21 17:40:24 +0000 Commit: Konstantin Belousov <[email protected]> CommitDate: 2021-10-21 18:40:46 +0000 subr_firmware.c::unloadentry(): remote write-only variable The function ignores result returned by linker_release_module(). The FW_UNLOAD flag on the file is cleared, so even on error it would not be tried again. Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/kern/subr_firmware.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index 0465f2a88483..aafb2a2ba265 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -412,7 +412,6 @@ static void unloadentry(void *unused1, int unused2) { struct priv_fw *fp; - int err; mtx_lock(&firmware_mtx); restart: @@ -434,7 +433,7 @@ restart: * on unload to actually free the entry. */ mtx_unlock(&firmware_mtx); - err = linker_release_module(NULL, NULL, fp->file); + (void)linker_release_module(NULL, NULL, fp->file); mtx_lock(&firmware_mtx); /*
