On Sat, Feb 05, 2022 at 03:55:32PM +0000, Richard Scheffenegger wrote: R> The branch main has been updated by rscheff: R> R> URL: https://cgit.FreeBSD.org/src/commit/?id=1790549d801f65266811c49c0741ffedf722170e R> R> commit 1790549d801f65266811c49c0741ffedf722170e R> Author: Richard Scheffenegger <[email protected]> R> AuthorDate: 2022-02-05 15:50:21 +0000 R> Commit: Richard Scheffenegger <[email protected]> R> CommitDate: 2022-02-05 15:55:22 +0000 R> R> tcp: use TCPSTAT_INC in kernel ecn functions R> R> Incorrectly used KMOD_ marco in static kernel ECN functions. R> R> Both eventually resolve to counter_s64_add(), but better R> use the correct macros.
Yep. The non-kmod version will calculate stat offset at compile time and counter_u64_add() will be inlined. This all will end in literally one instruction (on amd64) instead of a function call. -- Gleb Smirnoff
