On 12 Sept 2022, at 04:53, Jessica Clarke <[email protected]> wrote: > > On 12 Sept 2022, at 03:36, Adrian Chadd <[email protected]> wrote: >> >> The branch main has been updated by adrian: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=7d0e83c60bedf601e61d80187cdfa785fa4b1963 >> >> commit 7d0e83c60bedf601e61d80187cdfa785fa4b1963 >> Author: Adrian Chadd <[email protected]> >> AuthorDate: 2022-09-11 23:57:52 +0000 >> Commit: Adrian Chadd <[email protected]> >> CommitDate: 2022-09-12 02:36:42 +0000 >> >> arm: add dwc3/xhci as build options for ARM > > dwc3 already was there?
Also, xhci already exists for arm and pulls in the generic PCI-based XHCI driver in sys/conf/files. What you really mean is that you added generic_xhci(_fdt) to arm kernels as needed by dwc3. Jess >> Summary: >> This mirrors the recentish changes to armv8; the ipq4018 port uses >> dwc3 + xhci and thus needs this. >> >> Subscribers: imp, andrew >> >> Reviewed by: imp >> >> Differential Revision: https://reviews.freebsd.org/D36530 > > This is not the right format for commit messages. > > Jess > >> --- >> sys/conf/files.arm | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/sys/conf/files.arm b/sys/conf/files.arm >> index 85afa4893d3c..c7e8a52a813d 100644 >> --- a/sys/conf/files.arm >> +++ b/sys/conf/files.arm >> @@ -99,7 +99,10 @@ dev/psci/psci.c optional psci >> dev/psci/smccc_arm.S optional psci >> dev/syscons/scgfbrndr.c optional sc >> dev/uart/uart_cpu_fdt.c optional uart fdt >> -dev/usb/controller/dwc3.c optional fdt dwc3 >> + >> +dev/usb/controller/dwc3.c optional fdt dwc3 >> +dev/usb/controller/generic_xhci.c optional xhci >> +dev/usb/controller/generic_xhci_fdt.c optional xhci fdt >> >> kern/msi_if.m optional intrng >> kern/pic_if.m optional intrng >
