The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=f0a15aafcb863f796e2a7f94d0fd8a857fb56103
commit f0a15aafcb863f796e2a7f94d0fd8a857fb56103 Author: Jose Luis Duran <[email protected]> AuthorDate: 2022-10-28 09:20:33 +0000 Commit: Konstantin Belousov <[email protected]> CommitDate: 2022-10-29 21:09:32 +0000 strfmon: Remove XXX marks phantom@'s HDD crashed with the final version of strfmon.c, as explained in 9d430a5991d3f64a75fee951a1efab3593207832. Now there are tests in place that cover these code paths. Reviewed by: kib PR: 267410 Github PR: #620 MFC after: 1 week --- lib/libc/stdlib/strfmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libc/stdlib/strfmon.c b/lib/libc/stdlib/strfmon.c index aee053a26ec8..ba02544eb2ec 100644 --- a/lib/libc/stdlib/strfmon.c +++ b/lib/libc/stdlib/strfmon.c @@ -324,7 +324,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc, if (cs_precedes == 1) { if (sign_posn == 1 || sign_posn == 3) { PRINTS(signstr); - if (sep_by_space == 2) /* XXX: ? */ + if (sep_by_space == 2) PRINT(' '); } @@ -363,7 +363,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc, || sign_posn == 2 || sign_posn == 4))) PRINT(space_char); - PRINTS(currency_symbol); /* XXX: len */ + PRINTS(currency_symbol); if (sign_posn == 4) { if (sep_by_space == 2) PRINT(' '); @@ -597,7 +597,7 @@ __format_grouped_double(double value, int *flags, } if ((*flags & NEED_GROUPING) && - thousands_sep_size > 0 && /* XXX: need investigation */ + thousands_sep_size > 0 && *grouping != CHAR_MAX && *grouping > 0) { while (avalue_size > (int)*grouping) {
