On 12/7/22 9:45 AM, Gleb Smirnoff wrote:
Doug,
On Wed, Dec 07, 2022 at 01:54:10PM +0000, Doug Rabson wrote:
D> commit eb6f48854df20441b384ca36b6b31558ada087c9
D> Author: Doug Rabson <[email protected]>
D> AuthorDate: 2022-12-07 13:40:18 +0000
D> Commit: Doug Rabson <[email protected]>
D> CommitDate: 2022-12-07 13:51:34 +0000
D>
D> Fix a typo in the binmisc option name
D>
D> This should be spelt IMGACT_BINMISC to match the filename. The option
D> name does not appear outside of sys/conf and this module is typically
D> used via the kernel module imgact_binmisc.ko.
D>
D> MFC After: 2 weeks
My custom kernel has been broken by this change. I don't think you want to
MFC that and you might think of reverting it at all. The option has been
used for quite a long time to change its name. May be rename the file
instead?
No, it was a clear typo. All the other image activators follow the existing
pattern (imgact_elf.c, imgact_aout.c, imgact_shell.c). Maybe a note in
UPDATING, but I suspect there are very few users compiling this into custom
kernels in practice.
--
John Baldwin
