Dima Panov wrote: > It breaks the build %( > > > In file included from > /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken.c:70: > /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken_wcwidth.h:132:7: > error: call to undeclared function 'bitcount'; ISO C99 and later do not > support implicit function declarations > [-Werror,-Wimplicit-function-declaration] > if (bitcount(bytes[0] & 0xf0) != nbytes) > ^ > 1 error generated. > *** [teken.o] Error code 1
The cross builds had succeeded on GitHub's Actions, our local machines and the FreeBSD cluster, so we thought it was good to go. Apparently, the code should call __bitcount() which is defined in sys/types.h (included in teken/teken.h), instead of bitcount(), which is defined in sys/libkern.h and is not included. I am pushing a fix right now. Unfortunately, since all the machines I keep trying to clean build on succeed, we'll have to wait for feedback again to be sure that the fix is working... Christos
