The branch stable/14 has been updated by tuexen:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=fc40509e72efe4f9249f48bbe48098690a709fb3

commit fc40509e72efe4f9249f48bbe48098690a709fb3
Author:     Michael Tuexen <[email protected]>
AuthorDate: 2024-05-10 18:58:01 +0000
Commit:     Michael Tuexen <[email protected]>
CommitDate: 2024-08-03 22:27:53 +0000

    sctp: improve heartbeat timer computation
    
    PR:             278666
    Reviewed by:    Albin Hellqvist
    Pull Request:   https://reviews.freebsd.org/D45107
    
    (cherry picked from commit 5120ea0d8871fd5d56a8fb70117b727b9d8a4e62)
---
 sys/netinet/sctputil.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/sys/netinet/sctputil.c b/sys/netinet/sctputil.c
index e963c5cb466e..fd11a7ece5b7 100644
--- a/sys/netinet/sctputil.c
+++ b/sys/netinet/sctputil.c
@@ -2289,19 +2289,19 @@ sctp_timer_start(int t_type, struct sctp_inpcb *inp, 
struct sctp_tcb *stcb,
                } else {
                        to_ticks = net->RTO;
                }
-               rndval = sctp_select_initial_TSN(&inp->sctp_ep);
-               jitter = rndval % to_ticks;
-               if (to_ticks > 1) {
-                       to_ticks >>= 1;
-               }
-               if (jitter < (UINT32_MAX - to_ticks)) {
-                       to_ticks += jitter;
-               } else {
-                       to_ticks = UINT32_MAX;
-               }
                if (!((net->dest_state & SCTP_ADDR_UNCONFIRMED) &&
                    (net->dest_state & SCTP_ADDR_REACHABLE)) &&
                    ((net->dest_state & SCTP_ADDR_PF) == 0)) {
+                       if (to_ticks > 1) {
+                               rndval = sctp_select_initial_TSN(&inp->sctp_ep);
+                               jitter = rndval % to_ticks;
+                               to_ticks >>= 1;
+                               if (jitter < (UINT32_MAX - to_ticks)) {
+                                       to_ticks += jitter;
+                               } else {
+                                       to_ticks = UINT32_MAX;
+                               }
+                       }
                        if (net->heart_beat_delay < (UINT32_MAX - to_ticks)) {
                                to_ticks += net->heart_beat_delay;
                        } else {

Reply via email to